-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump go-version to 1.21.9 for release-3.5 due to CVE-2023-45288 #17708
Bump go-version to 1.21.9 for release-3.5 due to CVE-2023-45288 #17708
Conversation
Hi @henrybear327. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reference: - PR etcd-io#17703 Signed-off-by: Chun-Hung Tseng <[email protected]>
Signed-off-by: Chun-Hung Tseng <[email protected]>
dd1c159
to
600b6bf
Compare
Question: why bump golang.org/x/net to v0.23.0 in the second commit? Did you see any issue if not bumping it? |
Sorry for not being clear on this second commit. The vulnerability scan on CI will report an error, thus, I decided to upgrade to the version specified up there. Log extract:
|
Thanks for the clarification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks.
Extracted log from govulncheck, suggesting that we should bump the version of golang.org/x/net === Symbol Results === Vulnerability #1: GO-2024-2687 HTTP/2 CONTINUATION flood in net/http More info: https://pkg.go.dev/vuln/GO-2024-2687 Module: golang.org/x/net Found in: golang.org/x/[email protected] Fixed in: golang.org/x/[email protected] Reference: - etcd-io#17708 Signed-off-by: Chun-Hung Tseng <[email protected]>
Extracted log from govulncheck, suggesting that we should bump the version of golang.org/x/net === Symbol Results === Vulnerability #1: GO-2024-2687 HTTP/2 CONTINUATION flood in net/http More info: https://pkg.go.dev/vuln/GO-2024-2687 Module: golang.org/x/net Found in: golang.org/x/[email protected] Fixed in: golang.org/x/[email protected] Reference: - etcd-io#17708 Signed-off-by: Chun-Hung Tseng <[email protected]>
Extracted log from govulncheck, suggesting that we should bump the version of golang.org/x/net === Symbol Results === Vulnerability #1: GO-2024-2687 HTTP/2 CONTINUATION flood in net/http More info: https://pkg.go.dev/vuln/GO-2024-2687 Module: golang.org/x/net Found in: golang.org/x/[email protected] Fixed in: golang.org/x/[email protected] Reference: - etcd-io#17708 Signed-off-by: Chun-Hung Tseng <[email protected]>
Extracted log from govulncheck, suggesting that we should bump the version of golang.org/x/net === Symbol Results === Vulnerability #1: GO-2024-2687 HTTP/2 CONTINUATION flood in net/http More info: https://pkg.go.dev/vuln/GO-2024-2687 Module: golang.org/x/net Found in: golang.org/x/[email protected] Fixed in: golang.org/x/[email protected] Reference: - etcd-io#17708 Signed-off-by: Chun-Hung Tseng <[email protected]>
Extracted log from govulncheck, suggesting that we should bump the version of golang.org/x/net === Symbol Results === Vulnerability #1: GO-2024-2687 HTTP/2 CONTINUATION flood in net/http More info: https://pkg.go.dev/vuln/GO-2024-2687 Module: golang.org/x/net Found in: golang.org/x/[email protected] Fixed in: golang.org/x/[email protected] Reference: - etcd-io#17708 Signed-off-by: Chun-Hung Tseng <[email protected]>
Reference:
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.