Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] backport etcdserver: skip when detect a removed peer #17536

Closed

Conversation

datbeohbbh
Copy link
Contributor

backport #17518 to release-3.4
resolve #17514

@k8s-ci-robot
Copy link

Hi @datbeohbbh. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fuweid
Copy link
Member

fuweid commented Mar 6, 2024

Too many goroutines running after all test(s).
1 instances of:
sync.runtime_SemacquireMutex(0x63?, 0x0?, 0x1?)
	/opt/hostedtoolcache/go/1.21.6/x64/src/runtime/sema.go:77 +0x25
sync.(*Mutex).lockSlow(...)
	/opt/hostedtoolcache/go/1.21.6/x64/src/sync/mutex.go:171 +0x15d
sync.(*Mutex).Lock(...)
	/opt/hostedtoolcache/go/1.21.6/x64/src/sync/mutex.go:90
go.etcd.io/bbolt.(*DB).removeTx(...)
	/home/runner/go/pkg/mod/go.etcd.io/[email protected]/db.go:838 +0x7e
go.etcd.io/bbolt.(*Tx).close(...)
	/home/runner/go/pkg/mod/go.etcd.io/[email protected]/tx.go:320 +0x9d
go.etcd.io/bbolt.(*Tx).nonPhysicalRollback(0x471272?)
	/home/runner/go/pkg/mod/go.etcd.io/[email protected]/tx.go:271 +0x45
go.etcd.io/bbolt.(*Tx).Rollback(0xc00465df50?)
	/home/runner/go/pkg/mod/go.etcd.io/[email protected]/tx.go:259 +0x25
go.etcd.io/etcd/mvcc/backend.(*batchTxBuffered).unsafeCommit.func1(0x7ff2f827b488?, 0xc005271b70?)
	/home/runner/work/etcd/etcd/mvcc/backend/batch_tx.go:335 +0x3a
created by go.etcd.io/etcd/mvcc/backend.(*batchTxBuffered).unsafeCommit in goroutine 1205
	/home/runner/work/etcd/etcd/mvcc/backend/batch_tx.go:333 +0xf9
FAIL	go.etcd.io/etcd/clientv3	0.273s
testing: warning: no tests to run

@fuweid
Copy link
Member

fuweid commented Mar 6, 2024

/retest

@ahrtr
Copy link
Member

ahrtr commented Mar 6, 2024

/ok-to-test

@ahrtr
Copy link
Member

ahrtr commented Mar 6, 2024

Too many goroutines running after all test(s).

The only reason is there was one write transaction which hasn't closed yet.

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serathius
Copy link
Member

No need to backport as this is not an issue based on #17518 (comment)

@serathius serathius closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants