Remove workflow telemetry github action #17131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have completed memory profiling for our workflows so can consider removing this additional action now. Signed-off-by: James Blair <[email protected]>
ahrtr
approved these changes
Dec 18, 2023
ivanvc
reviewed
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently in #17045 we introduced a new github action to etcd testing workflows that run on
arm64so that we could tune the memory requests of those workflows in an evidence based way.We have now completed that tuning, with workflows being reduced from
32GBram to8GBram which also includes plenty of headroom based on current utilisation where workflows generally all sit below5GB:With the tuning complete I propose we turn off collecting the detailed performance telemetry for every workflow as it creates quite noisy summaries and some error annotations on our workflows, for example: https://github.com/etcd-io/etcd/actions/runs/7231109865.
We can always turn it back on sometime in future if performance profiling is required again.