-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-3.5] etcdserver: add cluster id check for hashKVHandler #16637
[release-3.5] etcdserver: add cluster id check for hashKVHandler #16637
Conversation
32a4053
to
90f81e4
Compare
Signed-off-by: caojiamingalan <[email protected]> Signed-off-by: Marek Siarkowicz <[email protected]>
b3ecb90
to
277570f
Compare
…eady notification infinitely on startup" Signed-off-by: Marek Siarkowicz <[email protected]>
277570f
to
5b8150a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a minor comment.
@@ -12,11 +12,15 @@ | |||
// See the License for the specific language governing permissions and | |||
// limitations under the License. | |||
|
|||
//go:build !cluster_proxy | |||
// +build !cluster_proxy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no such build tag in #15924.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport of #15924 to release-3.5