fix:Ensure that go version is only defined in one file for release-3.5 #16562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmhbnz
reviewed
Sep 9, 2023
There was a problem hiding this comment.
Hey @MeenuyD - Thanks for fixing this and congrats on your first contribution to etcd 🎉
The change looks good to me, however to make sure we can merge this can you please ensure your commit is signed so the DCO check passes.
You can sign your commit by doing the following:
git rebase HEAD~1 --signoff
git push --force
|
In my same branch |
Yes, please run those commands locally in your terminal, they will sign your commit and push the update to this pull request. |
Signed-off-by: MeenuyD <[email protected]>
MeenuyD
force-pushed
the
go-version-update
branch
from
bbe226e to
078b080
Compare
jmhbnz
approved these changes
Sep 10, 2023
serathius
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that we can update the Golang patch version for release-3.5 by only updating a single file.
#16560