replace github.com/gyuho/gocovmerge with github.com/wadey/gocovmerge #16384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
added
dependencies
jmhbnz
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
LGTM
Note: Found a copy of the repo in waybackmachine: https://web.archive.org/web/20201023134702/https://github.com/gyuho/gocovmerge
Looks like at that point in 2020 it was just two commits ahead of wadey/gocovmerge.
Edit - There are a number of forks of that original repo and this one https://github.com/alexfalkowski/gocovmerge does look to be getting more maintenance so we could consider that option also.
…ovmerge github.com/gyuho/gocovmerge has already been removed or turned into a private repo. I believe it's also forked from github.com/wadey/gocovmerge. So replace it with the original repo github.com/alexfalkowski/gocovmerge. Signed-off-by: Benjamin Wang <[email protected]>
ahrtr
force-pushed
the
coverage_20230807
branch
from
d912b19 to
acfa46c
Compare
Good point! Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16322
github.com/gyuho/gocovmergehas already been removed or turned into a private repo. I believe it's also forked fromgithub.com/wadey/gocovmerge. So replace it with the original repogithub.com/wadey/gocovmerge.Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.