Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/robustness: Create dedicated traffic package #15845

Merged
merged 1 commit into from
May 9, 2023
Merged

test/robustness: Create dedicated traffic package #15845

merged 1 commit into from
May 9, 2023

Conversation

serathius
Copy link
Member

@lavacat
Copy link

lavacat commented May 8, 2023

Seams like there are couple minor refactors besides creating traffic package:

  • config FailpointConfig was removed, I assume for better readability
  • type watchConfig was added, not clear why

Can you add brief list of minor refactors in commit body?

In terms of traffic package - I didn't review actual logic, assuming this is copy/paste.
Overall LGTM

@serathius serathius force-pushed the robustness-traffic branch from 177ec69 to ad20230 Compare May 9, 2023 08:52
@serathius
Copy link
Member Author

Removed the additional changes. PTAL

ahrtr
ahrtr approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @serathius

@serathius serathius merged commit d81d3c3 into etcd-io:main May 9, 2023
@serathius serathius deleted the robustness-traffic branch June 15, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serathius @lavacat @ahrtr