-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add riscv64 support #15490
feat: add riscv64 support #15490
Conversation
147d958
to
2f6685f
Compare
Dockerfile-release.riscv64
Outdated
@@ -0,0 +1,13 @@ | |||
FROM --platform=linux/ppc64le riscv64/debian:sid-slim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New releases were migrated to gcr.io/distroless/static-debian11
Don't think we want to have use different images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried it first, but there is no riscv64 image for gcr.io/distroless/static-debian11, so I've found a closest replacement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously I saws lots of CVEs, so eventually we migrated to distroless base image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no distroless image for riscv64, and I can't add it to distroless repo myself until riscv64 snapshots for debian packages are available.
Should I try riscv64/busybox instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to use busybox due to licensing issues #15034
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like FROM scratch
just works.
Looks like it would be currently hard to add riscv64 to distroless, please see GoogleContainerTools/distroless#1268. Can we use |
Dockerfile-release.riscv64
Outdated
@@ -0,0 +1,13 @@ | |||
FROM --platform=linux/ppc64le riscv64/debian:sid-slim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously I saws lots of CVEs, so eventually we migrated to distroless base image.
Need to agree with distroless maintainer arches to the build is quite expensive and makes it harder to maintain. Especially if we would need to use separate base image for riscv64. For now I'm against adding support riscv64 until https://www.debian.org/ports/ and distroless supports it |
01ef2b9
to
8dfc570
Compare
Signed-off-by: Aleksandr Razumov <[email protected]>
Closing this until distroless dependency is resolved. Will be maintaining forks and binaries under https://github.com/go-riscv. Also, there is signed distroless image from go-riscv: docker pull ghcr.io/go-riscv/distroless/static-unstable:latest FROM ghcr.io/go-riscv/distroless/static-unstable:latest |
Should be marked as Tier 3.