client: enhance the function shouldRetryWatch and added unit test #14935
Conversation
Signed-off-by: Benjamin Wang <[email protected]>
ahrtr
force-pushed
the
minor_enhance_error_20221213
branch
2 times, most recently
from
0845b67 to
4437ce1
Compare
…gGRPCAuthOldRevision to cache gRPC error messages Signed-off-by: Benjamin Wang <[email protected]>
ahrtr
force-pushed
the
minor_enhance_error_20221213
branch
from
4437ce1 to
d0e753c
Compare
Codecov Report
@@ Coverage Diff @@
## main #14935 +/- ##
==========================================
- Coverage 74.59% 74.57% -0.02%
==========================================
Files 415 415
Lines 34338 34339 +1
==========================================
- Hits 25613 25608 -5
- Misses 7082 7084 +2
- Partials 1643 1647 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Probably I won't be able to have time for following the k8s side discussion until weekend... sorry for that. I think having something like |
| name: "invalid grpc error and not equal to ErrGRPCInvalidAuthToken or ErrGRPCAuthOldRevision", | ||
| msg: "whatever error message", | ||
| expectedRetry: false, | ||
| }, |
There was a problem hiding this comment.
Now msg: "" is a special codepath - so probably worth having a testcase.
There was a problem hiding this comment.
Eventually we need to revert the change and need to add a field something like ReasonCode in the WatchResponse. Or just rollback the change, do not fix it at all. What's your thought?
Resolve the comment kubernetes/kubernetes#114403 (comment)
Signed-off-by: Benjamin Wang [email protected]
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
cc @mitake @spzala