Deflake transport timeout case #14861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is data race on `stop` channel. After verify write-timeout successfully, the case won't wait for `blocker` to receive close signal from `stop` channel. If the new `blocker`, which is to read-timeout verifier, get dial's result immediately, the new `blocker` might fetch the message from `stop` channel before old one and then close the connection, which causes that the `conn.Read` returns `EOF` when it reads data. How to reproduce this in linux devbox? Use `taskset` to limit the test process in one-cpu. ```bash cd ./client/pkg/transport go test -c -o /tmp/test --race=true ./ taskset -c 0 /tmp/test -test.run TestWriteReadTimeoutListener -test.v -test.cpu 4 -test.count=10000 -test.failfast ``` To fix this, suggest to use seperate `stop` channel to prevent from data race. Signed-off-by: Wei Fu <[email protected]>
Signed-off-by: Wei Fu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #14861 +/- ##
==========================================
- Coverage 75.56% 75.33% -0.23%
==========================================
Files 457 457
Lines 37423 37423
==========================================
- Hits 28278 28194 -84
- Misses 7371 7443 +72
- Partials 1774 1786 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
serathius
approved these changes
Nov 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is data race on
stopchannel. After verify write-timeout successfully, the case won't wait forblockerto receive close signal fromstopchannel. If the newblocker, which is to read-timeout verifier, get dial's result immediately, the newblockermight fetch the message fromstopchannel before old one and then close the connection, which causes that theconn.ReadreturnsEOFwhen it reads data.How to reproduce this in linux devbox?
Use
tasksetto limit the test process in one-cpu.To fix this, suggest to use seperate
stopchannel to prevent from data race.Signed-off-by: Wei Fu [email protected]
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
REF: #14834 (comment)