Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump github.com/stretchr/testify from v1.7.2 to v1.8.1 #14856

Merged
merged 1 commit into from
Nov 26, 2022

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Nov 26, 2022

I introduced github.com/stretchr/testify v1.8.1 into gofail, while etcd is still depending on v1.7.2. It causes the linearizability CI failure. So bump to v1.8.1.

Signed-off-by: Benjamin Wang [email protected]

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

cc @serathius @spzala @ptabor

@codecov-commenter
Copy link

Codecov Report

Merging #14856 (285e443) into main (488e541) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #14856      +/-   ##
==========================================
- Coverage   75.59%   75.37%   -0.23%     
==========================================
  Files         457      457              
  Lines       37423    37416       -7     
==========================================
- Hits        28291    28201      -90     
- Misses       7358     7432      +74     
- Partials     1774     1783       +9     
Flag Coverage Δ
all 75.37% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/etcdserver/api/v3rpc/util.go 67.74% <0.00%> (-12.91%) ⬇️
server/etcdserver/api/rafthttp/peer_status.go 87.87% <0.00%> (-12.13%) ⬇️
server/etcdserver/api/rafthttp/peer.go 87.01% <0.00%> (-8.45%) ⬇️
client/pkg/v3/testutil/leak.go 62.83% <0.00%> (-7.08%) ⬇️
client/pkg/v3/fileutil/purge.go 68.85% <0.00%> (-6.56%) ⬇️
client/v3/namespace/watch.go 87.87% <0.00%> (-6.07%) ⬇️
raft/rafttest/node.go 95.00% <0.00%> (-5.00%) ⬇️
server/etcdserver/api/v3rpc/watch.go 82.22% <0.00%> (-4.13%) ⬇️
server/etcdserver/api/rafthttp/msgappv2_codec.go 69.56% <0.00%> (-3.48%) ⬇️
client/v3/leasing/util.go 95.00% <0.00%> (-3.34%) ⬇️
... and 18 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM(non-binding)

@ahrtr
Copy link
Member Author

ahrtr commented Nov 26, 2022

@serathius serathius merged commit 08cb83a into etcd-io:main Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants