-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display hash_revision for etcdctl endpoint hash
#14812
Conversation
d9a085b
to
10bceba
Compare
Codecov Report
@@ Coverage Diff @@
## main #14812 +/- ##
==========================================
- Coverage 75.64% 75.40% -0.25%
==========================================
Files 457 457
Lines 37391 37393 +2
==========================================
- Hits 28284 28195 -89
- Misses 7336 7415 +79
- Partials 1771 1783 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Some examples output.
|
b239362
to
33d9303
Compare
Rebased this PR and updated the examples for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Just a few nits.
Signed-off-by: Benjamin Wang <[email protected]>
Two chanages: 1. Add field `HashRevision` into `HashKVResponse`; 2. Display the new field when executing `etcdctl endpoint hash`. Signed-off-by: Benjamin Wang <[email protected]>
…sion Signed-off-by: Benjamin Wang <[email protected]>
Signed-off-by: Benjamin Wang <[email protected]>
Signed-off-by: Benjamin Wang <[email protected]>
33d9303
to
9a7f960
Compare
The server side change is done in #14537.
This PR is the etcdctl side change, and also cover the test.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.