Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raft: delete unused Ready.containsUpdates method #14722

Merged

Conversation

nvanbenschoten
Copy link
Contributor

The function was unused beyond its own unit test. Delete it.

Signed-off-by: Nathan VanBenschoten [email protected]

Extracted from #14627. cc. @tbg

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

Merging #14722 (0bff3ad) into main (0bff3ad) will not change coverage.
The diff coverage is n/a.

❗ Current head 0bff3ad differs from pull request most recent head e0beef6. Consider uploading reports for the commit e0beef6 to get more accurate results

@@           Coverage Diff           @@
##             main   #14722   +/-   ##
=======================================
  Coverage   75.58%   75.58%           
=======================================
  Files         457      457           
  Lines       37323    37323           
=======================================
  Hits        28211    28211           
  Misses       7342     7342           
  Partials     1770     1770           
Flag Coverage Δ
all 75.58% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrtr
Copy link
Member

ahrtr commented Nov 11, 2022

Always good to see code cleanup. Thank you @nvanbenschoten

@tbg tbg merged commit 22d930b into etcd-io:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants