Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Add linearizability tests scenario for #14370 #14611

Merged
merged 1 commit into from
Oct 25, 2022
Merged

tests: Add linearizability tests scenario for #14370 #14611

merged 1 commit into from
Oct 25, 2022

Conversation

serathius
Copy link
Member

@serathius serathius commented Oct 23, 2022 •
edited
Loading

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2022 •
edited
Loading

Codecov Report

Merging #14611 (e5790d2) into main (e5790d2) will not change coverage.
The diff coverage is n/a.

❗ Current head e5790d2 differs from pull request most recent head 6216d07. Consider uploading reports for the commit 6216d07 to get more accurate results

@@           Coverage Diff           @@
##             main   #14611   +/-   ##
=======================================
  Coverage   75.76%   75.76%           
=======================================
  Files         457      457           
  Lines       37267    37267           
=======================================
  Hits        28235    28235           
  Misses       7284     7284           
  Partials     1748     1748
Flag Coverage Δ
all 75.76% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@serathius serathius force-pushed the issue14370 branch 5 times, most recently from cd75983 to 6216d07 Compare October 23, 2022 11:27
@ahrtr
Copy link
Member

ahrtr commented Oct 24, 2022

Please fix the static analysis error.

@serathius serathius force-pushed the issue14370 branch 3 times, most recently from 6af0ccd to 6c78768 Compare October 24, 2022 11:24
ahrtr
ahrtr reviewed Oct 24, 2022
View reviewed changes
scripts/build_lib.sh Show resolved Hide resolved
scripts/build_lib.sh Show resolved Hide resolved
tests/linearizability/failpoints.go Show resolved Hide resolved
ahrtr
ahrtr approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serathius serathius merged commit 8ce81a1 into etcd-io:main Oct 25, 2022
@serathius serathius mentioned this pull request Oct 27, 2022
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serathius @codecov-commenter @ahrtr