Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functional_test: code cleanup and minor enhancements #14602

Merged
merged 1 commit into from
Oct 23, 2022

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Oct 20, 2022

  1. Cleaned up some useless or dead code;
  2. Remove some unnecessary methods.

Signed-off-by: Benjamin Wang [email protected]

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Cleaned up some useless or dead code;
Remove some unnecessary methods.

Signed-off-by: Benjamin Wang <[email protected]>
@ahrtr ahrtr force-pushed the enhance_functional_test_20221020 branch from 2aee420 to bbda1da Compare October 20, 2022 02:35
@codecov-commenter
Copy link

Codecov Report

Merging #14602 (bbda1da) into main (e24402d) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #14602      +/-   ##
==========================================
- Coverage   75.65%   75.50%   -0.16%     
==========================================
  Files         457      457              
  Lines       37300    37223      -77     
==========================================
- Hits        28220    28105     -115     
- Misses       7325     7350      +25     
- Partials     1755     1768      +13     
Flag Coverage Δ
all 75.50% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/etcdserver/api/v3lock/lock.go 61.53% <0.00%> (-8.47%) ⬇️
client/pkg/v3/tlsutil/tlsutil.go 83.33% <0.00%> (-8.34%) ⬇️
raft/rafttest/node.go 95.00% <0.00%> (-5.00%) ⬇️
api/etcdserverpb/raft_internal_stringer.go 76.78% <0.00%> (-4.94%) ⬇️
client/pkg/v3/testutil/leak.go 62.83% <0.00%> (-4.43%) ⬇️
client/v3/experimental/recipes/priority_queue.go 63.33% <0.00%> (-3.34%) ⬇️
server/etcdserver/api/v3rpc/member.go 93.54% <0.00%> (-3.23%) ⬇️
client/v3/experimental/recipes/double_barrier.go 71.87% <0.00%> (-3.13%) ⬇️
server/proxy/grpcproxy/watch.go 93.64% <0.00%> (-2.90%) ⬇️
client/v3/experimental/recipes/key.go 75.34% <0.00%> (-2.74%) ⬇️
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahrtr

@ahrtr ahrtr merged commit 61c8888 into etcd-io:main Oct 23, 2022
@ahrtr
Copy link
Member Author

ahrtr commented Oct 23, 2022

Thanks @spzala for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants