Simplify e2e coverage code #14596
Merged
Simplify e2e coverage code #14596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #14596 +/- ##
==========================================
- Coverage 75.64% 75.43% -0.21%
==========================================
Files 457 457
Lines 37213 37213
==========================================
- Hits 28149 28072 -77
- Misses 7310 7372 +62
- Partials 1754 1769 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Marek Siarkowicz <[email protected]>
Signed-off-by: Marek Siarkowicz <[email protected]>
Signed-off-by: Marek Siarkowicz <[email protected]>
Signed-off-by: Marek Siarkowicz <[email protected]>
Signed-off-by: Marek Siarkowicz <[email protected]>
Signed-off-by: Marek Siarkowicz <[email protected]>
…arios Signed-off-by: Marek Siarkowicz <[email protected]>
serathius
force-pushed
the
simplify-e2e-coverage
branch
from
4fa4bc3 to
1b3f301
Compare
ahrtr
reviewed
Oct 17, 2022
| env := mergeEnvVariables(envVars) | ||
| switch { | ||
| case strings.HasSuffix(cmd, "/etcd"): | ||
| cmd = cmd + "_test" |
There was a problem hiding this comment.
Do you understand why the _testsuffix was added in the first place?
cc @ptabor
There was a problem hiding this comment.
Yes, the coverage scenario compiles separate binaries with _test suffix.
There was a problem hiding this comment.
I was thinking removing the suffix "_test" may cause some issue. I just realized that you do not remove the suffix, which is hard coded in initBinPathCov.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @ahrtr @spzala @ptabor