Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate word in comments #14390

Merged
merged 1 commit into from
Aug 27, 2022
Merged

chore: remove duplicate word in comments #14390

merged 1 commit into from
Aug 27, 2022

Conversation

Abirdcfly
Copy link

Signed-off-by: Abirdcfly [email protected]

@Abirdcfly
Copy link
Author

Another chore is that the go fmt raft/log_test.go will find that the comments format needs to be updated, but the version of go used by etcd is 1.17 (by go.mod). My local version of go is 1.19, so I didn't update this issue.

diff --git a/raft/log_test.go b/raft/log_test.go
index 0ad23f93b..f8b325c14 100644
--- a/raft/log_test.go
+++ b/raft/log_test.go
@@ -146,12 +146,14 @@ func TestAppend(t *testing.T) {

 // TestLogMaybeAppend ensures:
 // If the given (index, term) matches with the existing log:
-//     1. If an existing entry conflicts with a new one (same index
-//     but different terms), delete the existing entry and all that
-//     follow it
-//     2.Append any new entries not already in the log
+//  1. If an existing entry conflicts with a new one (same index
+//     but different terms), delete the existing entry and all that
+//     follow it
+//     2.Append any new entries not already in the log
+//
 // If the given (index, term) does not match with the existing log:
-//     return false
+//
+//     return false

@ahrtr

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants