-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcdctl: add --max-txn-ops flag to make-mirror command #14340
Conversation
Overall looks good to me, but please keep it consistent with the existing flag in etcd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add an item into the changelog-3.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xakdwch We should update README as well - https://github.com/etcd-io/etcd/blob/main/etcdctl/README.md#make-mirror-options-destination Also, as @ahrtr pointed out, please update the CHANGELOG.
--max-txn-ops flag allows users to define the maximum number of operations permitted in a transaction during syncing updates.if unlimited syncing may fail when number of txn ops exceeds the maximum number of server side. Signed-off-by: xakdwch <[email protected]>
ack and updated |
updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xakdwch
lgtm. The build failure not related, re-running.
what is this
--max-txn-ops flag allows users to define the maximum number of operations permitted in
a transaction during syncing updates.if unlimited syncing may fail when number of txn ops
exceeds the maximum number of server side.
why need this
DefaultMaxTxnOps in server side is 128. it also can be defined by the --max-txn-ops flag in etcd server side.
if the number of operations permitted per transaction exceeds the limitation during make-mirror,
make-mirror will crash.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.