[3.4] Bump to prometheus/client_golang v1.11.1 #14191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptabor
approved these changes
Jul 4, 2022
spzala
approved these changes
Jul 4, 2022
Cherry pick etcd-io#13895 to 3.4. Signed-off-by: Benjamin Wang <[email protected]>
ahrtr
force-pushed
the
3.4_backport_prometheus_client
branch
from
70c0592 to
7f41da6
Compare
|
Bumping
I think we would be better not to bump prometheus/client_golang, and keep it as it so as to minimize the impact. Based on CVE-2022-21698, etcd isn't affected. So I would like to give up this PR, and move it out of 3.4.19. Please let me know if you have any concern. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick #13895 to 3.4.
Signed-off-by: Benjamin Wang [email protected]
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.