[3.4] Fix pipeline failures in 3.4 #14183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refer to the following commit in 3.5, etcd-io@093282f Signed-off-by: Benjamin Wang <[email protected]>
Fix the following error in integration pipeline,
```
=== RUN TestTLSReloadCopy
v3_grpc_test.go:1754: tls: failed to find any PEM data in key input
v3_grpc_test.go:1754: tls: private key does not match public key
v3_grpc_test.go:1754: tls: private key does not match public key
v3_grpc_test.go:1754: tls: private key does not match public key
```
Refer to https://github.com/etcd-io/etcd/runs/7123775361?check_suite_focus=true
Signed-off-by: Benjamin Wang <[email protected]>
ahrtr
changed the title
…pported by gRPC proxy. Signed-off-by: Benjamin Wang <[email protected]>
|
@spzala @ptabor @serathius This is anther big step towards to stabilizing 3.4 pipeline. The first big step is pull/14136. All changes are for the test, there is no any changes for the production code. Some other PRs are blocked by this one. Please take a look, thanks. |
serathius
approved these changes
Jun 30, 2022
|
Since all changes are only for test, so it should be safe. All some other PRs are blocked by this on. So I will merge this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved items:
TestCtlV3WatchClientTLS failure
Also refer to the following commit in 3.5,
093282f5eab8b5ba5613b48594aed8794a757c8a
replace all certificates in 3.4 with files from 3.5
Fix the following error in integration pipeline,
Refer to https://github.com/etcd-io/etcd/runs/7123775361?check_suite_focus=true
Disabled cases on certificate-based authentication for gprc-proxy
Certificate-based authentication isn't supported by gRPC proxy. The following cases are disabled for grpc-proxy,
Part of 14105
Signed-off-by: Benjamin Wang [email protected]
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.