Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up unnecessary stack log when restore #13767

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

kkkkun
Copy link
Contributor

@kkkkun kkkkun commented Mar 8, 2022

clean up stack log

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Merging #13767 (8800f0c) into main (8ac44ff) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13767      +/-   ##
==========================================
- Coverage   72.83%   72.80%   -0.03%     
==========================================
  Files         467      467              
  Lines       38280    38279       -1     
==========================================
- Hits        27880    27868      -12     
- Misses       8606     8610       +4     
- Partials     1794     1801       +7     
Flag Coverage Δ
all 72.80% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
etcdutl/snapshot/v3_snapshot.go 65.54% <ø> (-0.15%) ⬇️
server/auth/simple_token.go 80.00% <0.00%> (-8.47%) ⬇️
client/pkg/v3/fileutil/purge.go 66.03% <0.00%> (-7.55%) ⬇️
server/storage/mvcc/watchable_store.go 85.14% <0.00%> (-3.99%) ⬇️
server/etcdserver/api/v3rpc/member.go 93.54% <0.00%> (-3.23%) ⬇️
client/v3/leasing/txn.go 88.09% <0.00%> (-3.18%) ⬇️
server/etcdserver/util.go 85.71% <0.00%> (-3.18%) ⬇️
pkg/traceutil/trace.go 96.15% <0.00%> (-1.93%) ⬇️
server/etcdserver/api/v3rpc/watch.go 85.90% <0.00%> (-1.35%) ⬇️
client/v3/leasing/cache.go 91.66% <0.00%> (-1.12%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ac44ff...8800f0c. Read the comment docs.

@kkkkun kkkkun changed the title clean up stack log when restore clean up unnecessary stack log when restore Mar 8, 2022
@serathius serathius merged commit 85d4567 into etcd-io:main Mar 8, 2022
@kkkkun kkkkun deleted the delete-restore-stack branch March 11, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants