server: Make --v2-deprecation=write-only the default and remove not-y… #13612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serathius
force-pushed
the
write-only
branch
3 times, most recently
from
d39d697 to
5794c68
Compare
ahrtr
reviewed
Feb 6, 2022
| @@ -17,7 +17,7 @@ package config | |||
| type V2DeprecationEnum string | |||
|
|
|||
| const ( | |||
| // Default in v3.5. Issues a warning if v2store have meaningful content. | |||
| // No longer supported in v3.6 | |||
| V2_DEPR_0_NOT_YET = V2DeprecationEnum("not-yet") | |||
There was a problem hiding this comment.
If it is not supported in 3.6, can we just remove it and remove the switch case at line 40?
There was a problem hiding this comment.
I'm also usually for removing the dead code, however in this case I think it's worth to leave for historical context. Of course when V2 is fully removed this whole file should be deleted, however I think it's worth to keep this so that someone reading this file understands all previous enum stages.
There was a problem hiding this comment.
Sure, it isn't a big deal. Feel free to keep it unchanged.
It's OK because this file will eventually be removed.
ptabor
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…et option
Part of #12913