etcdutl: Implement migrate --force command #13220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serathius
force-pushed
the
migrateforce
branch
2 times, most recently
from
e9c9433 to
e7df6c0
Compare
13 tasks
nic-chen
reviewed
Jul 18, 2021
serathius
force-pushed
the
migrateforce
branch
5 times, most recently
from
0f26fe5 to
fdbeac5
Compare
|
Fixed all issues, PTAL. |
nic-chen
approved these changes
Jul 19, 2021
yuzhiquan
reviewed
Jul 20, 2021
|
/lgtm |
serathius
force-pushed
the
migrateforce
branch
2 times, most recently
from
4ea35fa to
0ddc5b3
Compare
ptabor
approved these changes
Aug 2, 2021
| force: o.force, | ||
| } | ||
| var err error | ||
| dotCount := strings.Count(o.targetVersion, ".") |
There was a problem hiding this comment.
Would the line 82 succeed if the version didn't contain "." ?
There was a problem hiding this comment.
No, semver parsing always requires "Major.Minor.Patch". Here we just hardcode patch to 0.
I think we should have a special struct just to represent "Major.Minor" instead of reusing semver
There was a problem hiding this comment.
I see: It's just about adding more human friendly error...
serathius
force-pushed
the
migrateforce
branch
3 times, most recently
from
8becbbf to
2f8532d
Compare
Co-authored-by: nic-chen <[email protected]> Co-authored-by: Heisenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13168
Part of #13168
This PR adds an
etcdutl migrate --forcecommand that is able to migrate schema of data located in etcd data dir. Implementing only force as we need an escape hatch for uses that depend on running etcd from older versions.Implementation of migrate will be added in next milestones when we will have full schema in place.
cc @lilic @ptabor