Make Junit report success callout message conditional #13154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @serathius @ptabor |
Rajalakshmi-Girish
force-pushed
the
junit__test_report
branch
from
ec50c94 to
09db47f
Compare
|
/recheck |
Rajalakshmi-Girish
force-pushed
the
junit__test_report
branch
2 times, most recently
from
2e41fbf to
286c334
Compare
Rajalakshmi-Girish
force-pushed
the
junit__test_report
branch
from
286c334 to
a78f01a
Compare
|
I think we should instead use other way to install it. Current way of installing gotestsum is not used in other places, we use gobin like 8a5733c. |
|
I think best would be to close this PR to avoid conflicts. I'm still finding small problems with this script, for example with cross compilation, so I would prefer to do a thorough testing before merging. |
|
#13152 shall take care of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gotestsum error messages like
./scripts/test_lib.sh: line 240: gotestsum: command not foundgo unnoticed.In spite of this error message, the current logic at https://github.com/etcd-io/etcd/blob/main/scripts/test_lib.sh#L245 misguides that the Junit report is saved.
Hence this PR is to add the neccessary addition of
$GOPATH/binto$PATHand making the log_callout message conditional.