client/v3/maintenance.go: Add Downgrade support to client #13083
+27
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this for testing the downgrade feature, requesting it via the client works correctly, but downgrade itself fails for me. I am not sure if we want to merge this now already due to that or wait until we adjust the downgrade itself?
I setup my etcd cluster and requested the dowgrade via this client, from 3.5.0 -> 3.4.16. But in the downgrade code we call this function:
etcd/server/etcdserver/cluster_util.go
Lines 479 to 480 in e2d67f2
this discards the patch version I passed so my downgrade fails. I am not sure why we want to do this, as I find it useful to be able to downgrade to the latest 3.4.16 for example?
cc @serathius @ptabor @retroflexer @hexfusion
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.