Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--v2-deprecation flag: opt-in mode to validate that store-v2 has no user-content #12943

Merged
merged 4 commits into from
May 13, 2021

Conversation

ptabor
Copy link
Contributor

@ptabor ptabor commented May 10, 2021

The PR adds --v2-deprecation flag that allows to opt-in for a stage of v2 compatiblity, as documented in:
https://github.com/etcd-io/etcd/issues/12913\

TODO: Will add tests to this PR, but asking for early feedback.

@codecov-commenter
Copy link

Codecov Report

Merging #12943 (bda0926) into master (e892d6d) will decrease coverage by 0.07%.
The diff coverage is 68.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12943      +/-   ##
==========================================
- Coverage   72.86%   72.78%   -0.08%     
==========================================
  Files         430      432       +2     
  Lines       34240    34286      +46     
==========================================
+ Hits        24948    24956       +8     
- Misses       7358     7375      +17     
- Partials     1934     1955      +21     
Flag Coverage Δ
all 72.78% <68.75%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/config/config.go 74.24% <ø> (ø)
server/etcdserver/api/membership/store.go 49.70% <ø> (ø)
server/embed/etcd.go 69.04% <33.33%> (-0.22%) ⬇️
server/etcdserver/server.go 79.41% <38.46%> (-0.41%) ⬇️
server/embed/config.go 70.26% <50.00%> (-0.27%) ⬇️
server/etcdserver/api/membership/storev2.go 66.66% <66.66%> (ø)
server/config/v2_deprecation.go 90.90% <90.90%> (ø)
server/etcdmain/config.go 83.66% <100.00%> (+0.60%) ⬆️
server/etcdserver/api/v3rpc/lease.go 71.83% <0.00%> (-8.46%) ⬇️
client/pkg/v3/tlsutil/tlsutil.go 83.33% <0.00%> (-8.34%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e892d6d...bda0926. Read the comment docs.

Copy link
Contributor

@hexfusion hexfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thanks @ptabor

@ptabor ptabor force-pushed the 20210430-v2-deprecation-flags branch from bda0926 to 449ae26 Compare May 12, 2021 14:10
@ptabor ptabor force-pushed the 20210430-v2-deprecation-flags branch from 9b28219 to 70567fb Compare May 12, 2021 16:41
@ptabor ptabor force-pushed the 20210430-v2-deprecation-flags branch from 70567fb to 79e3d7b Compare May 12, 2021 17:21
@ptabor
Copy link
Contributor Author

ptabor commented May 12, 2021

Added e2e tests coverage in the last commit.

@ptabor ptabor merged commit 178fb87 into etcd-io:master May 13, 2021
@ptabor ptabor deleted the 20210430-v2-deprecation-flags branch May 13, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants