Verification of persisted data #12901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpbetz
reviewed
Apr 27, 2021
| if index > hardstate.Commit { | ||
| return fmt.Errorf("backend.ConsistentIndex (%v) must be < WAL.HardState.commit (%v)", index, hardstate.Commit) | ||
| } | ||
| if cfg.ExactIndex && index != hardstate.Commit { |
There was a problem hiding this comment.
Move this check above if index > hardstate.Commit check?
There was a problem hiding this comment.
Done (but not sure about the motivation)
| Logger *zap.Logger | ||
| } | ||
|
|
||
| func Verify(cfg Config) error { |
There was a problem hiding this comment.
Do we need to document any non-obvious expectations this function has? E.g. Since it opens a backend, is it required that the backend not already be open?
ptabor
force-pushed
the
20210427-verification
branch
from
9310f85 to
e14a9fe
Compare
ptabor
force-pushed
the
20210427-verification
branch
from
e14a9fe to
9598517
Compare
For now verifies whete Backend.cindex is consistent with WAL log, but should get expanded to cover memberships & revisions.
Verification framework is integrated with: - integration tests (by default) - `ETCD_VERIFY=all etcdctl snapshot restore` command - etcd shutdown when running with `ETCD_VERIFY=all` env.
ptabor
force-pushed
the
20210427-verification
branch
from
9598517 to
c4b13a5
Compare
|
Thank you for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a package that contains encoded invariants about etcd data model.
This package is used by tests and (opt-in) in business logic.
The purpose is:
For now its seeded with 2 checks:
Verification framework is integrated with:
ETCD_VERIFY=all etcdctl snapshot restorecommandETCD_VERIFY=allenv.