Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embed: etcd.Close() is closing Errc() channel as well. #12828

Merged
merged 1 commit into from
Apr 7, 2021
Merged

embed: etcd.Close() is closing Errc() channel as well. #12828

merged 1 commit into from
Apr 7, 2021

Conversation

ptabor
Copy link
Contributor

@ptabor ptabor commented Apr 4, 2021

Inspired by #9612 by purpleidea@.

Preserved the possibility to call: etcd.Close() multiple close (not recommended, but seen in our tests).

@ptabor ptabor mentioned this pull request Apr 4, 2021
Closed
@purpleidea
Copy link
Contributor

@ptabor Cool to see some movement here! I bet my golang has improved since my old PR too ;)
Curious to know what your reasons for reviving this are...

Btw, If you liked that one, I'm sure you'd love digging into: #6042 -- I haven't had the time :(

Cheers!

@ptabor
Copy link
Contributor Author

ptabor commented Apr 5, 2021 •
edited
Loading

We are planning to release 3.5 in May. So scanning what can/should get merged.

A.d. #6042, I think it has been fixed in: #12702

@ptabor ptabor marked this pull request as draft April 5, 2021 22:11
@ptabor ptabor force-pushed the 20210404-embed-etcd branch from 3fe941f to 6b0ae91 Compare April 6, 2021 08:14
@ptabor ptabor marked this pull request as ready for review April 7, 2021 18:21
jingyih
jingyih approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

server/embed/etcd.go Show resolved Hide resolved
@ptabor ptabor force-pushed the 20210404-embed-etcd branch from 6b0ae91 to 5da9cac Compare April 7, 2021 23:19
@ptabor
Copy link
Contributor Author

ptabor commented Apr 7, 2021

Thank you for review !

@ptabor ptabor merged commit e776efb into etcd-io:master Apr 7, 2021
@ptabor ptabor deleted the 20210404-embed-etcd branch April 7, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingyih jingyih jingyih approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptabor @purpleidea @jingyih