Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cert generation Makefile to include configurable cert file names #12766

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

mrajashree
Copy link
Contributor

The example for using cfssl tool runs a Makefile to generate certs for the nodes whose IP addresses are provided in req-csr.json
Makefile generates the certs with names containing hardcoded IP addresses. This commit changes the Makefile to read the address from environment variables

@mrajashree mrajashree changed the title Update cert generation Makefile to include configurable IP addresses Update cert generation Makefile to include configurable cert file names Mar 11, 2021
@ptabor
Copy link
Contributor

ptabor commented Mar 11, 2021

Please fix:

'markdown_you' started at Thu Mar 11 20:17:41 UTC 2021
% 'eval' 'find . -name \*.md ! -path '\''*/vendor/*'\'' ! -path '\''./Documentation/*'\'' ! -path '\''./gopath.proto/*'\'' ! -path '\''./release/*'\'' -exec grep -E --color '\''[Yy]ou[r]?[ '\''\'\'''\''.,;]'\'' {} + || true'
FAIL: 'markdown_you_find_eschew_you' checking failed (printed output)
./hack/tls-setup/README.md:3. Set the following environment variables subsituting your IP address:

@ptabor ptabor merged commit d18ac20 into etcd-io:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants