Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: Customize simpleTokenTTL settings. #11979

Closed
wants to merge 0 commits into from
Closed

auth: Customize simpleTokenTTL settings. #11979

wants to merge 0 commits into from

Conversation

cfc4n
Copy link
Contributor

@cfc4n cfc4n commented Jun 5, 2020

auth: Customize simpleTokenTTL settings.

simple Token TTL default value is auth.simpleTokenTTL = 5 * time.Minute.

Sometimes, this value is not sufficient for use, I hope it can be given to the user to customize the setting.

Fixes #11978

@codecov-commenter
Copy link

Codecov Report

Merging #11979 into master will increase coverage by 0.06%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11979      +/-   ##
==========================================
+ Coverage   65.53%   65.59%   +0.06%     
==========================================
  Files         403      403              
  Lines       37306    37313       +7     
==========================================
+ Hits        24447    24474      +27     
+ Misses      11333    11300      -33     
- Partials     1526     1539      +13     
Impacted Files Coverage Δ
etcdserver/config.go 79.51% <ø> (ø)
etcdserver/server.go 75.43% <ø> (-0.31%) ⬇️
auth/simple_token.go 67.47% <80.00%> (-9.84%) ⬇️
auth/store.go 53.37% <100.00%> (+0.42%) ⬆️
embed/config.go 54.26% <100.00%> (+0.13%) ⬆️
embed/etcd.go 74.54% <100.00%> (+0.05%) ⬆️
etcdmain/config.go 84.14% <100.00%> (+0.07%) ⬆️
auth/options.go 37.50% <0.00%> (-55.00%) ⬇️
proxy/grpcproxy/register.go 72.50% <0.00%> (-10.00%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f91d6...10483ba. Read the comment docs.

@cfc4n cfc4n closed this Jun 6, 2020
@cfc4n
Copy link
Contributor Author

cfc4n commented Jun 6, 2020

Links: #11980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

auth: Customize simpleTokenTTL settings
2 participants