Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clientv3: cancel the client if there is no endpoint #11942

Merged
merged 1 commit into from
May 24, 2020
Merged

clientv3: cancel the client if there is no endpoint #11942

merged 1 commit into from
May 24, 2020

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented May 23, 2020

In newClient, if there is no endpoint, we should cancel the client before returning error.

Also fixed typo in error message.

spzala
spzala approved these changes May 23, 2020
View reviewed changes
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Thanks!

@tedyu
Copy link
Contributor Author

tedyu commented May 24, 2020

@spzala
Can this be merged ?

@spzala
Copy link
Member

spzala commented May 24, 2020

Merging @tedyu as it's straightforward. CI failure not related. /cc @gyuho

@spzala spzala merged commit 747ff75 into etcd-io:master May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spzala spzala spzala approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tedyu @spzala