Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver: Missing the cfg.Logger causes panic #11933

Merged
merged 1 commit into from
May 22, 2020
Merged

Conversation

needkane
Copy link
Contributor

@needkane needkane commented May 22, 2020

Please read https://github.com/etcd-io/etcd/blob/master/CONTRIBUTING.md#contribution-flow.

In "etcdserver/server.go",function “applyEntryNormal” calls “applyV2Request“ ,and “applyV2Request” calls “Put” when etcd application starts.

There is log output in this function ("Put"), or log will be added later, but "a.lg" is nil when function is executed causes panic.

Test :

You can add ' fmt.Println(a.lg, "-----------applierV2store Put 67--------") ' to the
'func (a *applierV2store) Put(r *RequestV2) Response'

@needkane
Copy link
Contributor Author

/cc @jingyih @gyuho

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thx

@gyuho gyuho merged commit 4c9571d into etcd-io:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants