clientv3: non-recursive Watch() #11922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
reviewed
May 20, 2020
gyuho
reviewed
May 20, 2020
gyuho
reviewed
May 20, 2020
gyuho
reviewed
May 20, 2020
|
@tedyu Thanks for the PR. Now the watch code is easier to read :) |
tedyu
force-pushed
the
non-recursive-watch
branch
from
4695dcf to
acda472
Compare
gyuho
reviewed
May 20, 2020
tedyu
force-pushed
the
non-recursive-watch
branch
from
acda472 to
f1e26c6
Compare
Signed-off-by: Ted Yu <[email protected]>
tedyu
force-pushed
the
non-recursive-watch
branch
from
f1e26c6 to
f976138
Compare
|
lgtm |
|
@gyuho |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently watcher#Watch() is recursive.
This PR replaces the recursion with a for loop.
Prior to the PR,
is placed at the end of Watch().
For recursion involving Watch(), the above code is not executed, except for the most deeply nested Watch(). Meaning closeCh is not closed.
This bug is fixed with this PR