auth_command: create etcdctl auth status command

[tarcinil]

This changes have started at etcdctl under auth.go, and make changes to stub out everything down into the internal raft. Made changes to the .proto files and regenerated them so that the local version would build successfully.

fixes #11516

[codecov-io]

Codecov Report

Merging #11536 into master will decrease coverage by 0.58%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master   #11536      +/-   ##
==========================================
- Coverage   64.25%   63.66%   -0.59%     
==========================================
  Files         403      403              
  Lines       38091    38116      +25     
==========================================
- Hits        24475    24268     -207     
- Misses      11979    12204     +225     
- Partials     1637     1644       +7

Impacted Files	Coverage Δ
etcdserver/api/v3rpc/auth.go	43.67% <0%> (-2.67%)	⬇️
proxy/grpcproxy/auth.go	32.07% <0%> (-1.93%)	⬇️
proxy/grpcproxy/adapter/auth_client_adapter.go	33.33% <0%> (-1.97%)	⬇️
etcdserver/v3_server.go	70.61% <0%> (-2.9%)	⬇️
clientv3/auth.go	48.75% <0%> (-4.5%)	⬇️
etcdserver/apply.go	77.04% <0%> (-0.6%)	⬇️
clientv3/retry.go	68.42% <0%> (-1.23%)	⬇️
etcdserver/apply_auth.go	55.72% <0%> (-0.87%)	⬇️
etcdctl/ctlv3/command/auth_command.go	38.98% <40%> (+0.34%)	⬆️
client/client.go	53.26% <0%> (-11.77%)	⬇️
... and 28 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 574ee42...98c7290. Read the comment docs.

[tarcinil]

I have worked further on what I believe is a mostly working command. I don't have a good idea on how to remove the &{} stuff from the output. Any additional input you could give would be helpful.

Thanks.

$ ./bin/etcdctl auth status            
Authentication Status:  &{false}

$ ./bin/etcdctl auth enable                
Authentication Enabled

$ ./bin/etcdctl auth status --user root    
Password: 
Authentication Status:  &{true}

EDIT: I have figured it out. It no longer has a &{}.

[mitake]

@tarcinil thanks for the PR! I'd like to review it. But before that could you reorganize your commits with below rules for easier review?

• our typical commit log is formatted like this: package name: description of your change
• refactoring commits e.g. gofmt error fix shouldn't be an independent commit, could you squash them to suitable commits?

[tarcinil]

@mitake Let me know if that is the change to the commit that you had in mind.

[tarcinil]

Forcing Travis Build as the test that failed didn't have to do with my work and they passed before squash. Brittle test?

[mitake]

Could you squash 1st, 2nd, 4th and 5th commits into a single commit? The commit log should be *: add a new API and command for checking auth status.
Also you can drop 3rd commit because authStore.IsAuthEnabled() can be reused for the purpose and the method already has its tests.

Thanks a lot for your PR!

[mitake]

AuthStatus() isn't required. After fixing it I think this PR can be merged. Could you cross check @xiang90 @gyuho @jingyih ?

[mitake]

LGTM, thanks a lot @tarcinil !
Could you cross check this PR @xiang90 @gyuho @jingyih ?

[jingyih]

Overall looks good. Thanks! We also need to highlight this change in CHANGELOG-3.5.

[xiang90]

lgtm

[xiang90]

@tarcinil can you add this to the changelog?

[jingyih]

LGTM. Thanks!

[tarcinil]

I will look at doing the changelog tonight.

[tarcinil]

@xiang90 Changelog has been added. I created an entry for etcdctl and API as it technically covers both.

[xiang90]

lgtm