Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvcc/kvstore:fixcompactbug #11400

Merged
merged 1 commit into from
Nov 27, 2019
Merged

mvcc/kvstore:fixcompactbug #11400

merged 1 commit into from
Nov 27, 2019

Conversation

WIZARD-CXY
Copy link
Contributor

@WIZARD-CXY WIZARD-CXY commented Nov 27, 2019

fix issue #11392

@codecov-io
Copy link

Codecov Report

Merging #11400 into master will decrease coverage by 0.39%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #11400     +/-   ##
=========================================
- Coverage   64.74%   64.34%   -0.4%     
=========================================
  Files         403      403             
  Lines       37973    37974      +1     
=========================================
- Hits        24585    24436    -149     
- Misses      11761    11893    +132     
- Partials     1627     1645     +18
Impacted Files Coverage Δ
mvcc/kvstore_compaction.go 90.24% <100%> (+0.24%) ⬆️
auth/options.go 47.5% <0%> (-45%) ⬇️
pkg/transport/timeout_conn.go 60% <0%> (-20%) ⬇️
clientv3/balancer/utils.go 88.46% <0%> (-11.54%) ⬇️
auth/simple_token.go 77.23% <0%> (-9.76%) ⬇️
pkg/netutil/netutil.go 63.11% <0%> (-7.38%) ⬇️
clientv3/naming/grpc.go 68.42% <0%> (-7.02%) ⬇️
lease/leasehttp/http.go 64.23% <0%> (-4.38%) ⬇️
proxy/grpcproxy/watch.go 88.75% <0%> (-4.15%) ⬇️
auth/store.go 62.32% <0%> (-3.58%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 419ffb7...655df65. Read the comment docs.

Copy link
Contributor

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jingyih jingyih merged commit ccc52be into etcd-io:master Nov 27, 2019
jingyih added a commit that referenced this pull request Nov 27, 2019
…0-upstream-release-3.4

Automated cherry pick of #11400 on release 3.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants