Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /v3 suffix to go.mod and update import paths #11221

Closed
wants to merge 1 commit into from
Closed

Add /v3 suffix to go.mod and update import paths #11221

wants to merge 1 commit into from

Conversation

fiorix
Copy link

@fiorix fiorix commented Oct 9, 2019

This is an attempt to resolve #11154 by completing the migration to Go
modules. This is a breaking change to anyone using Go older than 1.11.

On Go 1.11 or newer, with or without modules, the "go.etcd.io/etcd"
import path should still work.

Users that have already adopted modules are then encouraged to use the
new, versioned import path "go.etcd.io/etcd/v3" in their projects.

Please read https://github.com/etcd-io/etcd/blob/master/CONTRIBUTING.md#contribution-flow.

This is an attempt to resolve #11154 by completing the migration to Go
modules. This is a breaking change to anyone using Go older than 1.11.

On Go 1.11 or newer, with or without modules, the "go.etcd.io/etcd"
import path should still work.

Users that have already adopted modules are then encouraged to use the
new, versioned import path "go.etcd.io/etcd/v3" in their projects.
@fiorix
Copy link
Author

fiorix commented Oct 9, 2019

Sending this mainly to see if travis would pass. No expectation that it will be merged.

@fiorix
Copy link
Author

fiorix commented Oct 9, 2019

Interesting, the binaries such as etcd-dump-logs get stuck on the incompatible version:

can't load package: package go.etcd.io/etcd/tools/etcd-dump-logs: module go.etcd.io/etcd@latest (v3.3.15+incompatible) found, but does not contain package go.etcd.io/etcd/tools/etcd-dump-logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

go get error for 3.4.0
1 participant