embed: expose ZapLoggerBuilder #11147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes the ZapLoggerBuilder in the embed.Config to allow for custom loggers to be defined and used by embedded etcd. Fixes etcd-io#11144
|
/cc @gyuho |
gyuho
approved these changes
Sep 13, 2019
|
@spzala Can you help with backport? |
gyuho
added a commit
that referenced
this pull request
Sep 13, 2019
…-upstream-release-3.4 Automated cherry pick of #11147
spzala
added a commit
to spzala/etcd
that referenced
this pull request
Sep 13, 2019
Update from etcd-io#11147 and etcd-io#11148
|
I just created an issue suggesting exposing zap.Logger rather than zap.Config (which is pretty simple) so that a zapcore.Core wrap can be configured, allowing users to do advanced configurations to zap, including filtering of messages, generating metrics, etc. My use case is mostly being able to mute very noisey messages from clientv3 & embed selectively, while keeping a good log level. #12326 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the ZapLoggerBuilder in the embed.Config to allow for
custom loggers to be defined and used by embedded etcd.
Fixes #11144