Fix: interval tree complete implemention based on red-black tree

.gitignore

@@ -34,3 +34,5 @@ vendor/**/*
 vendor/**/*_test.go
 
 *.bak
+
+.vscode/

auth/range_perm_cache.go

@@ -28,8 +28,8 @@ func getMergedPerms(lg *zap.Logger, tx backend.BatchTx, userName string) *unifie
 		return nil
 	}
 
-	readPerms := &adt.IntervalTree{}
-	writePerms := &adt.IntervalTree{}
+	readPerms := adt.NewIntervalTree()
+	writePerms := adt.NewIntervalTree()
 
 	for _, roleName := range user.Roles {
 		role := getRole(tx, roleName)

auth/range_perm_cache_test.go

@@ -48,7 +48,7 @@ func TestRangePermission(t *testing.T) {
 	}
 
 	for i, tt := range tests {
-		readPerms := &adt.IntervalTree{}
+		readPerms := adt.NewIntervalTree()
 		for _, p := range tt.perms {
 			readPerms.Insert(p, struct{}{})
 		}
@@ -89,7 +89,7 @@ func TestKeyPermission(t *testing.T) {
 	}
 
 	for i, tt := range tests {
-		readPerms := &adt.IntervalTree{}
+		readPerms := adt.NewIntervalTree()
 		for _, p := range tt.perms {
 			readPerms.Insert(p, struct{}{})
 		}

etcdserver/api/v3rpc/key.go

@@ -178,8 +178,8 @@ func checkTxnRequest(r *pb.TxnRequest, maxTxnOps int) error {
 // checkIntervals tests whether puts and deletes overlap for a list of ops. If
 // there is an overlap, returns an error. If no overlap, return put and delete
 // sets for recursive evaluation.
-func checkIntervals(reqs []*pb.RequestOp) (map[string]struct{}, adt.IntervalTree, error) {
-	var dels adt.IntervalTree
+func checkIntervals(reqs []*pb.RequestOp) (map[string]struct{}, *adt.IntervalTree, error) {
+	dels := adt.NewIntervalTree()
 
 	// collect deletes from this level; build first to check lower level overlapped puts
 	for _, req := range reqs {

mvcc/watcher_group.go

@@ -148,14 +148,15 @@ type watcherGroup struct {
 	// keyWatchers has the watchers that watch on a single key
 	keyWatchers watcherSetByKey
 	// ranges has the watchers that watch a range; it is sorted by interval
-	ranges adt.IntervalTree
+	ranges *adt.IntervalTree
 	// watchers is the set of all watchers
 	watchers watcherSet
 }
 
 func newWatcherGroup() watcherGroup {
 	return watcherGroup{
 		keyWatchers: make(watcherSetByKey),
+		ranges:      adt.NewIntervalTree(),
 		watchers:    make(watcherSet),
 	}
 }

pkg/adt/example_test.go

@@ -21,7 +21,7 @@ import (
 )
 
 func Example() {
-	ivt := &adt.IntervalTree{}
+	ivt := adt.NewIntervalTree()
 
 	ivt.Insert(adt.NewInt64Interval(1, 3), 123)
 	ivt.Insert(adt.NewInt64Interval(9, 13), 456)