-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile: Rebase etcd image to debian #10805
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10805 +/- ##
==========================================
+ Coverage 62.93% 64.97% +2.03%
==========================================
Files 400 401 +1
Lines 37646 39258 +1612
==========================================
+ Hits 23694 25508 +1814
+ Misses 12343 12112 -231
- Partials 1609 1638 +29
Continue to review full report at Codecov.
|
9d5fb52
to
f856ce9
Compare
cc @jingyih @hexfusion would you please take a look? Thanks! |
I think this was brought up during last community meeting and people agreed to make this in v3.4. I am adding the 3.4 milestone for now. Please let me know if I remembered incorrectly. cc @gyuho |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@wenjiaswe @jingyih Can we highlight this in changelog 3.4?
@gyuho thanks! I am working on the change log |
@wenjiaswe will this move to distroless later? |
To improve security and maintenance effort for etcd releases, it would
be ideal to rebase etcd base image from Alpine to Distroless. However,
note that distroless images by default do not contain a shell, etcd still has
shell scripts in https://github.com/etcd-io/etcd/tree/master/hack, I will
first rebase to Debian in v3.4.
This work is still in progress, open now to unveil any unexpected errors
from testing.
Fixes #10804
/cc @yuwenma