Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: Rebase etcd image to debian #10805

Merged
merged 1 commit into from
Jul 23, 2019

Conversation

wenjiaswe
Copy link
Contributor

@wenjiaswe wenjiaswe commented Jun 7, 2019

To improve security and maintenance effort for etcd releases, it would
be ideal to rebase etcd base image from Alpine to Distroless. However,
note that distroless images by default do not contain a shell, etcd still has
shell scripts in https://github.com/etcd-io/etcd/tree/master/hack, I will
first rebase to Debian in v3.4.

This work is still in progress, open now to unveil any unexpected errors
from testing.

Fixes #10804

/cc @yuwenma

@codecov-io
Copy link

codecov-io commented Jun 7, 2019

Codecov Report

Merging #10805 into master will increase coverage by 2.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10805      +/-   ##
==========================================
+ Coverage   62.93%   64.97%   +2.03%     
==========================================
  Files         400      401       +1     
  Lines       37646    39258    +1612     
==========================================
+ Hits        23694    25508    +1814     
+ Misses      12343    12112     -231     
- Partials     1609     1638      +29
Impacted Files Coverage Δ
proxy/grpcproxy/register.go 69.44% <0%> (-11.12%) ⬇️
clientv3/balancer/grpc1.7-health.go 46.22% <0%> (-5.82%) ⬇️
raft/rawnode.go 71.02% <0%> (-4.71%) ⬇️
pkg/adt/interval_tree.go 86.78% <0%> (-3.31%) ⬇️
raft/status.go 57.37% <0%> (-2.15%) ⬇️
raft/progress.go 93.71% <0%> (ø)
etcdmain/config.go 82.97% <0%> (+0.08%) ⬆️
etcdserver/api/rafthttp/transport.go 84.58% <0%> (+0.41%) ⬆️
mvcc/backend/batch_tx.go 58.37% <0%> (+0.6%) ⬆️
etcdserver/api/v3rpc/watch.go 79.08% <0%> (+0.65%) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe86a78...f856ce9. Read the comment docs.

@wenjiaswe wenjiaswe changed the title [WIP] DOCKERFILE: Rebase etcd image to debian DOCKERFILE: Rebase etcd image to debian Jun 18, 2019
@wenjiaswe wenjiaswe changed the title DOCKERFILE: Rebase etcd image to debian Dockerfile: Rebase etcd image to debian Jul 23, 2019
@wenjiaswe wenjiaswe force-pushed the rebase-distroless branch from 9d5fb52 to f856ce9 Compare July 23, 2019 01:58
@wenjiaswe
Copy link
Contributor Author

cc @jingyih @hexfusion would you please take a look? Thanks!

@jingyih
Copy link
Contributor

jingyih commented Jul 23, 2019

I think this was brought up during last community meeting and people agreed to make this in v3.4. I am adding the 3.4 milestone for now. Please let me know if I remembered incorrectly.

cc @gyuho

@jingyih jingyih added this to the etcd-v3.4 milestone Jul 23, 2019
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wenjiaswe @jingyih Can we highlight this in changelog 3.4?

@wenjiaswe
Copy link
Contributor Author

@gyuho thanks! I am working on the change log

@gyuho gyuho merged commit a904785 into etcd-io:master Jul 23, 2019
wenjiaswe added a commit that referenced this pull request Jul 23, 2019
@wenjiaswe wenjiaswe deleted the rebase-distroless branch October 15, 2019 18:06
@BenTheElder
Copy link

@wenjiaswe will this move to distroless later?
if not, how can we keep this in sync with the upstream debian-base?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Rebase etcd base image from alpine to distroless
5 participants