-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: update to Go 1.12.2 #10619
*: update to Go 1.12.2 #10619
Conversation
@@ -6,7 +6,7 @@ sudo: required | |||
services: docker | |||
|
|||
go: | |||
- 1.11.4 | |||
- 1.12 | |||
- tip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be explicitly 1.12.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks @hexfusion
Update to go 1.12.2 testing. Fixes etcd-io#10528
@hexfusion @gyuho I don't see any issue with build, format or unit test in my env. Thanks! |
Did we build and push the Go 1.12 based test image? |
@gyuho nope, not yet. That's where @hexfusion needs to help out :-) |
@spzala thanks for your patience test image is up |
@hexfusion @gyuho issue in Kube related to 1.12 https://groups.google.com/d/msg/kubernetes-dev/jmxp5ceglnY/qU7ufaLACQAJ and kubernetes/kubernetes#75833 |
The failure I see in build is fmt related and this error |
@gyuho @hexfusion I have created #10631 (merged this PR and #10441) I will keep this PR open as WIP but will close eventually in favor of the new PR if that makes sense. Thanks! |
@gyuho @hexfusion closing this one since we have Go 1.12.5 update in place under #10766 and we are doing test related updates in another PR as mentioned above. Thanks! |
Update to go 1.12.2 testing.
Fixes #10528