Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Replacing 'HTTP' by 'HTTPS' for securing links #10501

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

datuanmac
Copy link
Contributor

@datuanmac datuanmac commented Feb 26, 2019

Currently, when we access the URL http://www.grpc.io, it is redirected to https://www.grpc.io automatically.
So this commit aims to replace HTTP to HTTPs for security.

@codecov-io
Copy link

codecov-io commented Feb 26, 2019

Codecov Report

Merging #10501 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10501      +/-   ##
==========================================
- Coverage   71.59%   71.45%   -0.14%     
==========================================
  Files         393      393              
  Lines       36503    36503              
==========================================
- Hits        26136    26085      -51     
- Misses       8537     8575      +38     
- Partials     1830     1843      +13
Impacted Files Coverage Δ
client/keys.go 65.32% <0%> (-26.14%) ⬇️
pkg/tlsutil/tlsutil.go 86.2% <0%> (-6.9%) ⬇️
etcdserver/api/v3rpc/lease.go 71.59% <0%> (-5.69%) ⬇️
pkg/transport/listener.go 54.5% <0%> (-3.8%) ⬇️
etcdserver/api/v3rpc/watch.go 80.06% <0%> (-3.6%) ⬇️
proxy/httpproxy/director.go 80% <0%> (-2.86%) ⬇️
proxy/grpcproxy/register.go 83.33% <0%> (-2.78%) ⬇️
etcdserver/api/rafthttp/msgappv2_codec.go 69.56% <0%> (-1.74%) ⬇️
proxy/grpcproxy/watch.go 88.55% <0%> (-1.21%) ⬇️
etcdserver/cluster_util.go 58.74% <0%> (-0.9%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 918f041...32389b1. Read the comment docs.

@datuanmac
Copy link
Contributor Author

/retest

@xiang90
Copy link
Contributor

xiang90 commented Feb 26, 2019

@datuanmac

can you change the commit message to "doc: Replacing 'HTTP' by 'HTTPS' for securing links"? thanks.

@datuanmac datuanmac changed the title Replacing 'HTTP' by 'HTTPS' for securing links doc: Replacing 'HTTP' by 'HTTPS' for securing links Feb 27, 2019
@datuanmac
Copy link
Contributor Author

@datuanmac

can you change the commit message to "doc: Replacing 'HTTP' by 'HTTPS' for securing links"? thanks.

Thanks @xiang90. I just updated commit message.

@hexfusion
Copy link
Contributor

Hi @datuanmac he meant the actual git commit message itself, thanks!

ref: https://github.com/etcd-io/etcd/pull/10501/commits

@datuanmac
Copy link
Contributor Author

Hi @datuanmac he meant the actual git commit message itself, thanks!

ref: https://github.com/etcd-io/etcd/pull/10501/commits

Thanks @hexfusion

@datuanmac datuanmac force-pushed the replacing_http_by_https branch from 012ac28 to 32389b1 Compare February 27, 2019 03:12
Currently, when we access the URL https://www.grpc.io, it is redirected to https://www.grpc.io automatically.
So this commit aims to replace **HTTP** to **HTTPs** for security.
@xiang90
Copy link
Contributor

xiang90 commented Feb 27, 2019

lgtm

@xiang90 xiang90 merged commit 17de9bd into etcd-io:master Feb 27, 2019
@jingyih
Copy link
Contributor

jingyih commented Mar 4, 2019

cc @wenjiaswe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants