Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic when stopping etcd process #8916

Closed
hectorj2f opened this issue Nov 24, 2017 · 2 comments
Closed

Panic when stopping etcd process #8916

hectorj2f opened this issue Nov 24, 2017 · 2 comments
Labels
type/bug

Comments

@hectorj2f
Copy link

etcd v3.2.9

When stopping etcd, we always get the following panic error. Is there a way of gracefully stopping etcd ?

panic: Drain() is not implemented

goroutine 101105 [running]:
github.com/coreos/etcd/cmd/vendor/google.golang.org/grpc/transport.(*serverHandlerTransport).Drain(0xc4217b18c0)
	/home/gyuho/etcd/release/etcd/gopath/src/github.com/coreos/etcd/cmd/vendor/google.golang.org/grpc/transport/handler_server.go:374 +0x64
github.com/coreos/etcd/cmd/vendor/google.golang.org/grpc.(*Server).GracefulStop(0xc420464620)
	/home/gyuho/etcd/release/etcd/gopath/src/github.com/coreos/etcd/cmd/vendor/google.golang.org/grpc/server.go:1006 +0x2e6
github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd/embed.(*Etcd).Close.func2(0xc424b04300, 0xc4202f5cc0)
	/home/gyuho/etcd/release/etcd/gopath/src/github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd/embed/etcd.go:201 +0x54
created by github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd/embed.(*Etcd).Close
	/home/gyuho/etcd/release/etcd/gopath/src/github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd/embed/etcd.go:202 +0x20a
@Connor1996 Connor1996 mentioned this issue Nov 26, 2017
Merged
@gyuho
Copy link
Contributor

gyuho commented Nov 27, 2017

Suggestion from gRPC team grpc/grpc-go#1384 (comment)

@gyuho
Copy link
Contributor

gyuho commented Nov 29, 2017

Easy to repro: start a single node etcd cluster with TLS. Spawn a watcher. Stop etcd.

jamesdphillips added a commit to jamesdphillips/etcd that referenced this issue Dec 7, 2017
@jamesdphillips
Avoid panic when shutting down gRPC Server w/ TLS configuration
946760f 
Fixes: etcd-io#8916
Provided solution implements suggestion from gRPC team: grpc/grpc-go#1384 (comment)
jamesdphillips added a commit to jamesdphillips/etcd that referenced this issue Dec 7, 2017
@jamesdphillips
embed: Avoid panic when shutting down gRPC Server w/ TLS configuration
867c7ec 
Fixes: etcd-io#8916
Provided solution implements suggestion from gRPC team: grpc/grpc-go#1384 (comment)
jamesdphillips added a commit to jamesdphillips/etcd that referenced this issue Dec 7, 2017
@jamesdphillips
embed: Avoid panic when shutting down gRPC Server w/ TLS configuration
1f09680 
Fixes etcd-io#8916
Provided solution (attempts to) implements suggestion from gRPC team:  grpc/grpc-go#1384 (comment)
jamesdphillips added a commit to jamesdphillips/etcd that referenced this issue Dec 7, 2017
@jamesdphillips
embed: Avoid panic when shutting down gRPC Server
7caece4 
Avoid panic on shut down gRPC Server when TLS configuration is present.
Provided solution (attempts to) implements suggestion from gRPC team: grpc/grpc-go#1384 (comment).

Fixes etcd-io#8916
jamesdphillips added a commit to jamesdphillips/etcd that referenced this issue Dec 7, 2017
@jamesdphillips
embed: Avoid panic when shutting down gRPC Server
aae48b6 
Avoid panic when stopping gRPC Server if TLS configuration is present.
Provided solution (attempts to) implement suggestion from gRPC team: grpc/grpc-go#1384 (comment).

Fixes etcd-io#8916
@jamesdphillips jamesdphillips mentioned this issue Dec 7, 2017
Closed
@gyuho gyuho mentioned this issue Dec 7, 2017
Merged
gyuho pushed a commit to gyuho/etcd that referenced this issue Dec 7, 2017
@jamesdphillips @gyuho
embed: Avoid panic when shutting down gRPC Server
dac926d 
Avoid panic when stopping gRPC Server if TLS configuration is present.
Provided solution (attempts to) implement suggestion from gRPC team: grpc/grpc-go#1384 (comment).

Fixes etcd-io#8916
gyuho pushed a commit to gyuho/etcd that referenced this issue Dec 8, 2017
@jamesdphillips @gyuho
embed: Avoid panic when shutting down gRPC Server
e39915f 
Avoid panic when stopping gRPC Server if TLS configuration is present.
Provided solution (attempts to) implement suggestion from gRPC team: grpc/grpc-go#1384 (comment).

Fixes etcd-io#8916
@hongchaodeng hongchaodeng mentioned this issue Dec 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid panic on shut down when TLS configuration is present jamesdphillips/etcd
3 participants
@hectorj2f @xiang90 @gyuho