staticcheck: check unused, gosimple

[gyuho]

unused and gosimple have been deprecated (folded into staticcheck).

We have to make sure that we configure staticcheck to not miss any fmt tests from unused and gosimple, since I removed them in #10441.

[gyuho]

@hexfusion @spzala Can you look into these?

[spzala]

@gyuho thanks and sure, I will look into it. @hexfusion please let me know if you are already looking at it. I may need some help with this but will let you know. Thanks!

[hexfusion]

Go for it

…

On Fri, Feb 1, 2019 at 6:10 PM Sahdev Zala ***@***.***> wrote: @gyuho <https://github.com/gyuho> thanks and sure, I will look into it. @hexfusion <https://github.com/hexfusion> please let me know if you are already looking at it. I may need some help with this but will let you know. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10442 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABMR1QMrp4QEZdbGmQ7CRPU9IHfJFo1Qks5vJMlsgaJpZM4afH4D> .

-- —

[spzala]

@gyuho hi, for this issue, I should wait on #10441 to be merged or is it the other way that 10441 is waiting on this one? Thanks!

[spzala]

Related PR - #10631

[spzala]

@gyuho hello, I am closing this one as we have updated tests to meet the staticcheck requirements under #10631. Thanks!