Skip to content

Commit

Permalink
Documentation/upgrades: highlight "health", remove "errors" field
Browse files Browse the repository at this point in the history
Signed-off-by: Gyuho Lee <[email protected]>
  • Loading branch information
gyuho committed Jan 17, 2018
1 parent 96d7417 commit e83702e
Showing 1 changed file with 3 additions and 13 deletions.
16 changes: 3 additions & 13 deletions Documentation/upgrades/upgrade_3_3.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,27 +72,17 @@ cfg.SetupLogging()

Set `embed.Config.Debug` field to `true` to enable gRPC server logs.

#### Change in `/health` endpoint response value
#### Change in `/health` endpoint response

Previously, `[endpoint]:[client-port]/health` returned manually marshaled JSON value. 3.3 now defines [`etcdhttp.Health`](https://godoc.org/github.com/coreos/etcd/etcdserver/api/etcdhttp#Health) struct and includes errors, if any. Note that `"health"` field in `etcdhttp.Health` is `string` type (was boolean in v3.3.0-rc.0,1,2 but reverted to `string` for backward compatibilities).
Previously, `[endpoint]:[client-port]/health` returned manually marshaled JSON value. 3.3 now defines [`etcdhttp.Health`](https://godoc.org/github.com/coreos/etcd/etcdserver/api/etcdhttp#Health) struct.

Before
Note that in v3.3.0-rc.0, v3.3.0-rc.1, and v3.3.0-rc.2, `etcdhttp.Health` has boolean type `"health"` field and `"errors"` field. For backward compatibilities, we reverted `"health"` field to `string` type and removed `"errors"` field. Further health information would be provided in separate APIs.

```bash
$ curl http://localhost:2379/health
{"health":"true"}
```

After

```bash
$ curl http://localhost:2379/health
{"health":"true"}

# Or
{"health":"false","errors":["NOSPACE"]}
```

#### Change in gRPC gateway HTTP endpoints (replaced `/v3alpha` with `/v3beta`)

Before
Expand Down

0 comments on commit e83702e

Please sign in to comment.