Skip to content

Commit

Permalink
*: create project governance
Browse files Browse the repository at this point in the history
Create project governance.
  • Loading branch information
spzala committed Sep 30, 2019
1 parent 06ec6c4 commit b8574c6
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 17 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG-3.5.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,9 @@ Note that any `etcd_debugging_*` metrics are experimental and subject to change.
- Require [*Go 1.13+*](https://github.com/etcd-io/etcd/pull/11110).
- Compile with [*Go 1.13*](https://golang.org/doc/devel/release.html#go1.13)

### Project Governance

- The etcd team has added, a well defined and openly discussed, project [governance](https://github.com/etcd-io/etcd/pull/11175).

<hr>

16 changes: 4 additions & 12 deletions GOVERNANCE.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,22 +51,14 @@ to pick up the related work. At the very least, ensure the related work can be c
Afterward, create a pull request to remove yourself from the [MAINTAINERS](./MAINTAINERS)
file.

## Approvers

[Approvers](./MAINTAINERS) are contributors with merge rights. They are active reviewers
and have created significant numbers of PRs in the various code areas to add new features,
fix bugs and improve code. New approvers must be nominated by an existing maintainer
and must be elected by a supermajority of maintainers. Likewise, approvers can be removed
by a supermajority of the maintainers or can resign by notifying the maintainers.

## Reviewers

[Reviewers](./MAINTAINERS) are contributors who have demonstrated greater skill in
reviewing the code contribution from other contributors. Their LGTM counts towards
merging a code change into the project. New reviewers must be nominated by an existing
maintainer and must be elected by a supermajority of maintainers. Likewise, reviewers
can be removed by a supermajority of the maintainers or can resign by notifying the
maintainers.
merging a code change into the project. A reviewer is generally on the ladder towards
maintainership. New reviewers must be nominated by an existing maintainer and must be
elected by a supermajority of maintainers. Likewise, reviewers can be removed by a
supermajority of the maintainers or can resign by notifying the maintainers.

## Decision making process

Expand Down
6 changes: 1 addition & 5 deletions MAINTAINERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The official list of maintainers, approvers, and reviewers for the project maintenance.
# The official list of maintainers and reviewers for the project maintenance.
#
# Refer to the GOVERNANCE.md for description of the roles.
#
Expand All @@ -21,9 +21,5 @@ Xiang Li <[email protected]> (@xiang90) pkg:*
Ben Darnell <[email protected]> (@bdarnell) pkg:go.etcd.io/etcd/raft
Tobias Grieger <[email protected]> (@tbg) pkg:go.etcd.io/etcd/raft

# APPROVERS
Anthony Romano <[email protected]> (@heyitsanthony) pkg:*
Fanmin Shi <[email protected]> (@fanminshi) pkg:*

# REVIEWERS
Wenjia Zhang <[email protected]> (@wenjiaswe) pkg:*

0 comments on commit b8574c6

Please sign in to comment.