Skip to content

Commit

Permalink
docs: correct compaction period comments for 24-hour window
Browse files Browse the repository at this point in the history
Update compaction period logic in periodic compactor to consistently
use 24-hour intervals instead of 1-hour. This fixes incorrect time
calculations where:
- Compaction period now correctly uses 24-hour instead of 1-hour
- Revision recording interval updated to 144-minute (1/10 of 24-hour)
  instead of 6-minute
- Retry interval on compaction failure adjusted to 144-minute to
  match the new period

This ensures consistent time-based compaction behavior for 24-hour
windows as originally intended.

Fixes #[issue-19017]

Signed-off-by: wodeyoulai <[email protected]>
  • Loading branch information
wodeyoulai committed Jan 18, 2025
1 parent 2f37f48 commit 7da675a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions server/etcdserver/api/v3compactor/periodic.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,12 @@ Compaction period 1-hour:
- failure? update revs, and retry after 1/10 of 1-hour (6-minute)
Compaction period 24-hour:
1. compute compaction period, which is 1-hour
2. record revisions for every 1/10 of 1-hour (6-minute)
1. compute compaction period, which is 24-hour
2. record revisions for every 1/10 of 24-hour (144-minute)
3. keep recording revisions with no compaction for first 24-hour
4. do compact with revs[0]
- success? continue on for-loop and move sliding window; revs = revs[1:]
- failure? update revs, and retry after 1/10 of 1-hour (6-minute)
- failure? update revs, and retry after 1/10 of 24-hour (144-minute)
Compaction period 59-min:
1. compute compaction period, which is 59-min
Expand Down

0 comments on commit 7da675a

Please sign in to comment.