Merge pull request #11959 from tedyu/store-clone-rd-lock

etcdserver: take read lock when cloning store
etcd-io · Jun 3, 2020 · 62f1fef · 62f1fef
2 parents a09533d + 59ec251
commit 62f1fef
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/etcdserver/api/v2store/store.go b/etcdserver/api/v2store/store.go
@@ -755,7 +755,7 @@ func (s *store) SaveNoCopy() ([]byte, error) {
 }
 
 func (s *store) Clone() Store {
-	s.worldLock.Lock()
+	s.worldLock.RLock()
 
 	clonedStore := newStore()
 	clonedStore.CurrentIndex = s.CurrentIndex
@@ -764,7 +764,7 @@ func (s *store) Clone() Store {
 	clonedStore.Stats = s.Stats.clone()
 	clonedStore.CurrentVersion = s.CurrentVersion
 
-	s.worldLock.Unlock()
+	s.worldLock.RUnlock()
 	return clonedStore
 }