Skip to content

Commit

Permalink
retry_interceptor.go: Log the method that failed
Browse files Browse the repository at this point in the history
When getting warnings from the retry_interceptors that RPCs failed, they
provide very little context as to what exactly failed.

I used this patch to try debugging
https://groups.google.com/g/etcd-dev/c/3hxxr9ktdpM.
  • Loading branch information
Jille committed Jan 16, 2022
1 parent f4266e2 commit 3710083
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions client/v3/retry_interceptor.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ func (c *Client) unaryClientInterceptor(optFuncs ...retryOption) grpc.UnaryClien
c.GetLogger().Debug(
"retrying of unary invoker",
zap.String("target", cc.Target()),
zap.String("method", method),
zap.Uint("attempt", attempt),
)
lastErr = invoker(ctx, method, req, reply, cc, grpcOpts...)
Expand All @@ -63,6 +64,7 @@ func (c *Client) unaryClientInterceptor(optFuncs ...retryOption) grpc.UnaryClien
c.GetLogger().Warn(
"retrying of unary invoker failed",
zap.String("target", cc.Target()),
zap.String("method", method),
zap.Uint("attempt", attempt),
zap.Error(lastErr),
)
Expand Down

0 comments on commit 3710083

Please sign in to comment.