tests: add failpoint to simulate lack of disk space #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
reviewed
Jul 30, 2023
tx.go
Outdated
Comment on lines
190
to
192
| // gofail: var lackOfDiskSpace string | ||
| // return errors.New(lackOfDiskSpace) |
There was a problem hiding this comment.
It changes the behaviour. When grow() fails, it should execute tx.rollback().
Suggested change
| // gofail: var lackOfDiskSpace string | |
| // return errors.New(lackOfDiskSpace) | |
| // gofail: var lackOfDiskSpace string | |
| // tx.rollback() | |
| // return errors.New(lackOfDiskSpace) |
There was a problem hiding this comment.
Good to know. Fixed!
ahrtr
reviewed
Jul 30, 2023
tests/failpoint/db_failpoint_test.go
Outdated
Comment on lines
140
to
141
| err = tx.Rollback() | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
I believe it also needs to be updated after you fixed above comment.
There was a problem hiding this comment.
Makes sense. Fixed!
ahrtr
reviewed
Jul 31, 2023
| err = tx.Commit() | ||
| require.Error(t, err) | ||
| require.ErrorContains(t, err, "grow somehow failed") | ||
|
|
There was a problem hiding this comment.
Minor comment: Intentionally call Rollback, to ensure that the transaction has already been rollbacked.
Suggested change
| err = tx.Rollback() | |
| require.Error(t, err) | |
| require.ErrorIs(t, err, errors.ErrTxClosed) |
There was a problem hiding this comment.
Right, makes sense!
Signed-off-by: Marcondes Viana <[email protected]>
ahrtr
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #382
I added one more failpoint to simulate lack of disk space.