Utilisation d'un Mock pour tester url_extractor.ex #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
La fonction
get_resources_with_url_from_csvfait un appel exterieur (requête HEAD). Elle était testée via un doctest et c'est lors de ce doctest que régulièrement les tests échouent. Il est possible que cet échec aléatoire vienne du remplacement du moduleHTTPoisonlors de l'utilisation dewith_mockpar un autre test.Quoi qu'il en soit, il est plus propre d'en faire un test à part entière et d'avoir un mock (mox style) pour HTTPoison, et ainsi éviter les appels exterieurs lors des tests.
On va voir si ça résoud les problèmes de tests qui échouent et nous permettre de clôturer #1757 🤞
Première étape : est-ce que tests vont passer ? 😄